Updated assets/data.json to reflect #1727 fixes for development purposes & fix for #1460#1730
Conversation
…munity#1640) Scoped packages (starting with @) were losing their download counts because individual npm data was being overwritten during bulk merge. Now preserves existing npm data while still filling regular packages.
…to fix/1640-download-count
…fixes for development purposes
…eact-native-community#1460 use data.json from assets folder instead when ONLY_WRITE_LOCAL_DATA_FILE is set to true - useful in development mode
JairajJangle
changed the title
|
Hey @JairajJangle, thanks for working on the Vercel Blob issue! 👍 When it comes to the updating data JSON, usually this is done by maintainers, and only when we change the structure of entries, so the local dataset reflects the changes. What would be added by regeneration now is just missing download counts and several new entries, which should not hinder the development process. The reason for this approach is that reviewing diff on that file is quite hard, and updating that file often clobbers the git history a bit. So let's revert the data changes for now, I will follow up that soon, with some scheduled changes, the rest looks good! 👌 |
|
Hi @Simek! Sure, no problem! If that’s the case, totally understandable. I’ll go ahead and revert the assets/data.json changes and update the PR accordingly 👍 Thanks for the clarification! 🙌 EDIT: I have reverted the changes in assets/data.json and have updated the PR |
…nity#1727 fixes for development purposes" This reverts commit e6f7216.
Simek
left a comment
Simek
left a comment
There was a problem hiding this comment.
Thanks for working on the issue, and all other updates in the process, great job! 💪
2 participants
📝 Why & how
assets/data.jsonfile to reflect fix: preserve npm download data for scoped packages (fixes #1640) #1727 fixes for development purposes.ONLY_WRITE_LOCAL_DATA_FILEin build-and-score-data.ts.✅ Checklist